-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[+HOTFIX!] memory viewer: Close all instances after emulation exit #9594
Conversation
Is it legal to call delete on widgets? Otherwise idm probably isn't best tool for this task. |
It worked fine on my tests, @Megamouse is it safe to call delete on QDialog manually? This the main thread calling it. |
Qt has these two warnings about deleting objects:
https://doc.qt.io/qt-5/qobject.html#dtor.QObject The 2nd point is a bit dangerious, as f.ex. there might be a pending repaint event in the event loop. |
Fixed, made it use deleteLater() as QT spec recommends. |
9702706
to
3fb520e
Compare
So is this guaranteed to be always alive when idm is done? |
IDM is alive as long as emulation is running, debugger is alive as long as main_window is alive so basically all the time. |
Enhancmenets
Bugfixes